Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the logic for calculating running_count and total_count in the missed_blocks #548

Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Sep 17, 2024

Description

This PR removes the logic for calculating running_count and total_count in the missed_blocks table. We no longer need to store these values in the database since they can be easily derived with a simple query when necessary.

Previously, the calculation of these values could take several minutes when a validator missed a block, especially with large datasets. Now, only the consensus_address and block_missed are stored, which eliminates that overhead. The counts were not used in any endpoints or elsewhere in the code, so this cleanup improves performance without affecting functionality.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 changed the title Remove save block logic that was causing issues performance issues Removes the logic for calculating running_count and total_count in the missed_blocks Sep 19, 2024
@nullpointer0x00 nullpointer0x00 changed the title Removes the logic for calculating running_count and total_count in the missed_blocks Remove the logic for calculating running_count and total_count in the missed_blocks Sep 19, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review September 19, 2024 16:01
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner September 19, 2024 16:01
@nullpointer0x00 nullpointer0x00 merged commit 447fe17 into main Sep 19, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/remove-unneeded-save-missed-block-logic branch September 19, 2024 17:49
@nullpointer0x00 nullpointer0x00 self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants